Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined method `merge' for #<struct Riiif::ImageInformation #50

Closed
bess opened this issue Mar 15, 2017 · 1 comment
Closed

undefined method `merge' for #<struct Riiif::ImageInformation #50

bess opened this issue Mar 15, 2017 · 1 comment
Assignees
@bess
Labels
bug

Comments

@bess
Copy link
Collaborator

bess commented Mar 15, 2017

With riiif 1.1.2, I encounter a bug when rendering info.json manifests. It can't run #merge on a Riiif::ImageInformation struct. The bug is fixed if I add a #to_h, like this:

render json: image.info.to_h.merge(server_info), content_type: 'application/ld+json'

PR forthcoming.

screen shot 2017-03-15 at 2 13 10 pm
@bess bess self-assigned this Mar 15, 2017
@bess bess added the bug label Mar 15, 2017
@jcoyne
Copy link
Collaborator

jcoyne commented Mar 15, 2017

Looks like a resonable fix.

bess added a commit that referenced this issue Mar 16, 2017
@bess
Fixes #50: undefined method merge for struct Riiif::ImageInformation
494526d
@bess bess mentioned this issue Mar 16, 2017
Merged
bess added a commit that referenced this issue Mar 16, 2017
@bess
Fixes #50: undefined method merge for struct Riiif::ImageInformation
997c8de
@bess bess closed this as completed in #51 Mar 16, 2017
bess added a commit that referenced this issue Mar 16, 2017
@bess
Merge pull request #51 from curationexperts/no_merge_method_bug
6d1b816 
Fixes #50: undefined method merge for struct Riiif::ImageInformation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bess bess

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bess @jcoyne