-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collections: make 'back to search' behave in a consistent manner #26
Comments
Promoting to a bug because of the following behavior:
To a normal user, 'Back to Search' doesn't appear to do anything because it's target is set to the collection pid. |
The problem here is that "Home" is not a search, it's just a static page. It doesn't clear anything. When you click "back to search", you go to your last stored search. |
Should we make the home page visit act as a recorded "search"? |
Those questions are for @mark-dce |
I just realized this only happens on new browser sessions. I'm really open to you using your creativity here - the behavior I'm objecting to is having the "back to search" button take me to the collection I'm viewing, which clearly isn't a search and isn't actually back to the thing I was viewing last. The "back to search" can't just be the browser back button because if I click 'downgrade/upgrade to personal/course collection' or have just edited the title or description, the browser back still doesn't take me to a search page. It seems overly complicated, but having CuratedCollectionsController#show set the last stored search to something generic if it's not already set could work fine ACCEPTANCE
|
NOTE: Having just realized this only happens on brand new sessions, this is really minor, but I think this behavior makes the app look broken when it does occur. That being said, I'm willing to be overruled and close the ticket if the three of you don't agree with me and Tufts doesn't call this out as a bug to be fixed. |
The text was updated successfully, but these errors were encountered: