Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections: make 'back to search' behave in a consistent manner #26

Closed
1 task
mark-dce opened this issue Jul 3, 2014 · 7 comments
Closed
1 task
Assignees
Labels

Comments

@mark-dce
Copy link
Contributor

mark-dce commented Jul 3, 2014

  • Set the back to search link on collection views to point to /catalog?utf8=✓&search_field=all_fields&q=
@val99erie val99erie added this to the Week of July 14 milestone Jul 9, 2014
@mark-dce mark-dce changed the title Collections: search context (Bonus) Collections: make 'back to search' behave in a consistent manner Jul 14, 2014
@mark-dce mark-dce added bug and removed bug labels Jul 15, 2014
@mark-dce
Copy link
Contributor Author

Promoting to a bug because of the following behavior:

  1. Click on 'Home' or the 'Tufts Digital Image Library' target to clear active searches
  2. Click on any course or personal collection to view it
  3. Click on 'Back to Search'

To a normal user, 'Back to Search' doesn't appear to do anything because it's target is set to the collection pid.

@jcoyne
Copy link
Collaborator

jcoyne commented Jul 15, 2014

The problem here is that "Home" is not a search, it's just a static page. It doesn't clear anything. When you click "back to search", you go to your last stored search.

@jcoyne
Copy link
Collaborator

jcoyne commented Jul 15, 2014

Should we make the home page visit act as a recorded "search"?

@bmaddy
Copy link
Contributor

bmaddy commented Jul 15, 2014

Those questions are for @mark-dce

@mark-dce
Copy link
Contributor Author

I just realized this only happens on new browser sessions.

I'm really open to you using your creativity here - the behavior I'm objecting to is having the "back to search" button take me to the collection I'm viewing, which clearly isn't a search and isn't actually back to the thing I was viewing last.

The "back to search" can't just be the browser back button because if I click 'downgrade/upgrade to personal/course collection' or have just edited the title or description, the browser back still doesn't take me to a search page.

It seems overly complicated, but having CuratedCollectionsController#show set the last stored search to something generic if it's not already set could work fine

ACCEPTANCE

  1. When I clear my session data or open a new browser and visit the application root
  2. Then click on any personal or course collection link
  3. Then click on "Back to Search"
  • I should see the catalog index page for q='', fields='all_fields'

@mark-dce
Copy link
Contributor Author

NOTE: Having just realized this only happens on brand new sessions, this is really minor, but I think this behavior makes the app look broken when it does occur. That being said, I'm willing to be overruled and close the ticket if the three of you don't agree with me and Tufts doesn't call this out as a bug to be fixed.

@jcoyne jcoyne self-assigned this Jul 18, 2014
@jcoyne
Copy link
Collaborator

jcoyne commented Jul 18, 2014

@jcoyne jcoyne closed this as completed in 9bcacf1 Jul 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants