refac(purify): Add utils jsdoc & code consistency tasks #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssi02014
commented
Aug 3, 2023
| @@ -195,7 +196,7 @@ function createDOMPurify(window = getGlobal()) { | |||
| * @property {boolean} allowCustomizedBuiltInElements allow custom elements derived from built-ins if they pass CUSTOM_ELEMENT_HANDLING.tagNameCheck. Default: `false`. | |||
| */ | |||
| let CUSTOM_ELEMENT_HANDLING = Object.seal( | |||
| Object.create(null, { | |||
| create(null, { | |||
There was a problem hiding this comment.
Modified to import and utilize the create function from utils.js
ssi02014
commented
Aug 3, 2023
| return fun.apply(thisValue, args); | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
I placed it above construct (Reflect-related)
ssi02014
commented
Aug 3, 2023
| * @param {Function} func - The function to be wrapped and called. | ||
| * @returns {Function} A new function that applies the original function with provided thisArg and arguments. | ||
| */ | ||
| function unapply(func) { | ||
| return (thisArg, ...args) => apply(func, thisArg, args); | ||
| } |
There was a problem hiding this comment.
Apart from adding jsdoc, I moved export to the bottom.
ssi02014
commented
Aug 3, 2023
| @@ -9,12 +9,6 @@ const { | |||
| let { freeze, seal, create } = Object; // eslint-disable-line import/no-mutable-exports | |||
There was a problem hiding this comment.
I exported the create here.
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello 馃憢 @cure53
This time I added the jsdoc of the utils functions.
I also worked on consistency in the code, similar to before.
Please review this pull request to see if it's appropriate. 馃檹
Tasks