Add support for challenge cookie domain field #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
…r group(site) for the request Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
…ct' functions. Add sergroup to RInfo, and pass to map_request. Removed challenge_cookie_domain from security_policy. Updated options to $host/$domain. Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
…l-data. Cleanup, comment and format files Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
arbelaxRbz
requested review from
phil777,
xavier-rbz and
Aviv-Galmidi
as code owners
Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…kie_domain from the UI is an empty string Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
olgasobolevsky
previously approved these changes
Jun 22, 2023
Freakachoo
reviewed
Jun 22, 2023
Freakachoo
reviewed
Jun 22, 2023
Freakachoo
reviewed
Jun 22, 2023
Freakachoo
reviewed
Jun 22, 2023
Freakachoo
reviewed
Jun 22, 2023
Freakachoo
reviewed
Jun 22, 2023
Freakachoo
previously approved these changes
Jun 22, 2023
…only sites are needed). Fixed logs Signed-off-by: Arbel Axelrod <arbela@reblaze.com>
arbelaxRbz
dismissed stale reviews from Freakachoo and olgasobolevsky
via
0e0a653
This comment has been minimized.
This comment has been minimized.
E2E Test Statistics 1 files 1 suites 4m 8s ⏱️ Results for commit 0e0a653. |
olgasobolevsky
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read custom.json file as well, parse ‘sites’ and save in the config object.
Add and pass server group id to RInfo (like secpolid).
Add “Domain=” to the rbzid cookie, depending on the new field’s content.