Close the history channel on task cancellation. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 23, 2020 10:23
When the router task is cancelled, the channel remains open: the listener registered for the location changes stays attached and this leads to memory leaks and unwanted effects, especially when reloading the router is restarted later. With this change, the channel is closed when the task is cancelled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the router task is cancelled, the channel remains open: the listener registered for the location changes stays attached and this leads to memory leaks and unwanted effects, especially when reloading the router is restarted later.
With this change, the channel is closed when the task is cancelled.