toString doesn't always work on typed arrays #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
http://www.ecma-international.org/ecma-262/6.0/#sec-properties-of-the-%typedarrayprototype%-object link to relevant part of the spec. |
|
Thank you for spotting this! How would you like to be credited in the contributors file? |
|
Like this please. And thanks! Mitch Foley mitch@thefoley.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the spec, TypedArray does not define its own toString and inherits it directly from Object. In implementations that follow this (like SpiderMonkey), this causes the dictionary to be effectively empty. In v8, TypedArray's toString is somehow Array.prototype.toString. This fix just manually uses that toString.