Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox error when reaching the window bottom #37

Closed
nickbe opened this issue Sep 22, 2016 · 10 comments
Closed

Firefox error when reaching the window bottom #37

nickbe opened this issue Sep 22, 2016 · 10 comments
Labels

Comments

@nickbe
Copy link

nickbe commented Sep 22, 2016

As soon as the text reaches the bottom of the window, it's not possible to type anymore.
The cursor jumps "somewhere", but text input cannot be reached anymore.

@curiousdannii
Copy link
Owner

I can't reproduce this. If you're scrolled up then it won't take input, but if you're scrolled down and the cursor is visible or almost visible then it will scroll the cursor into view and accept text input.

@nickbe
Copy link
Author

nickbe commented Sep 23, 2016

Not here. If I reach the bottom then the input is out of sight

@curiousdannii
Copy link
Owner

I don't really know what you mean sorry. Can you add some screenshots maybe? (Or ideally a video)

@andrewschultz
Copy link

andrewschultz commented Sep 26, 2016

I'm seeing this problem, too, when I type in a command at the bottom of the window. But if I hit return again, the game text shows.

In fact, pushing any key after pushing return causes the previous move to show, but it seems like it is stuck on first impression.

I can provide screenshots if you need them. But the key thing seems to be that Parchment waits for an extra key press in my browser before showing the player the result of their move.

@andrewschultz
Copy link

To follow up, I'd like to note that this is a regression from January 20. What I did was to copy the zip file contents to c:\Program Files (x86)\Inform 7\Inform7\Extensions\Reserved\Templates\Parchment then rebuild my z-machine project. With the january 20 zip file it works okay. With the September 23 it does not. I can cut it down further later but I have an IFComp game to finish in the next few days :)

3d8cb2f#diff-9b4398a59f9a215eab27209e62e9ccae

@curiousdannii
Copy link
Owner

@andrewschultz Does it happen with a normal version of Parchment (either the one at iplayif.com or just using index.html), or only with the Inform 7 produced page?

@andrewschultz
Copy link

andrewschultz commented Sep 26, 2016

@curiousdannii it doesn't happen in my browser when I try to run Zork. It's only with the I7 produced page.

Also, I'm using 6G60. This may make a difference. I can check 6M briefly.

@nickbe
Copy link
Author

nickbe commented Sep 26, 2016

Well it doesn't do the automatic scrolling here. (Latest Firefox - Windows)

Cheers
Nick

Am 26. Sep. 2016, 09:29 +0200 schrieb Andrew Schultz notifications@github.com:

@curiousdannii (https://github.com/curiousdannii) it doesn't happen in my browser when I try to run Zork. It's only with the I7 produced page.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (#37 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AKYuDbuR4pQcQUQ9PosmK6ABEYKOD20Xks5qt3RagaJpZM4KEbV7).

@pteromys
Copy link

I suspect it's the overflow: hidden; introduced in 71fc32c.

Or at least, in a webpage exported from the latest gnome-inform7 (6M62) with parchment from current master, I can get scrolling to look right in a zblorb game if I remove the overflow: hidden; and width: 100% from #gameport.

Do you remember which glulx games and html templates were used to test 71fc32c? I'd like to see if I can make this work better with zblorbs from gnome-inform7 without breaking the progress made in that commit.

curiousdannii pushed a commit that referenced this issue Sep 16, 2019
In Inform7-6M62, the Standard template is incompatible with two of the
styles introduced in 71fc32c:

* "width: 100%" because the interpreter runs in div#gameport,
  whose width is the window width minus 15.4em;
* "overflow: hidden" because, at least the way ifvms.js does it now,
  nothing inside div#gameport has overflow: scroll or auto so this
  would break scrolling, which I think is the symptom seen in #37.

So override those styles in an embedded stylesheet in the HTML head
material provided to Inform 7.

Longer-term, if Inform 7 wants to use quixe through parchment rather
than as a separate template, it'll need to rename #gameport because the
id collides with an internal div used by quixe. (That or parchment can
rename gameport in quixe-runner.js, in (a) the HTML fragment and (b)
adding gameport: "whatever_the_new_name_is" to the set_page_title line;
but making that change would surprise anyone who has customized a
template with styles on #gameport.)
@curiousdannii
Copy link
Owner

This shouldn't be a problem with the new parchment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants