Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl-7.73.0_3-win64-mingw.zip has size 0.0 MB? #15

Closed
simon04 opened this issue Dec 2, 2020 · 5 comments
Closed

curl-7.73.0_3-win64-mingw.zip has size 0.0 MB? #15

simon04 opened this issue Dec 2, 2020 · 5 comments
Labels

Comments

@simon04
Copy link

simon04 commented Dec 2, 2020

On https://curl.se/windows/, the file https://curl.se/windows/dl-7.73.0_3/curl-7.73.0_3-win64-mingw.zip is listed with Size: 0.0 MB

@vszakats
Copy link
Member

vszakats commented Dec 2, 2020

Indeed, I also noticed it, but the linked file is the correct one.

Assuming this was something transient, I'm pushing a revision trying to fix this.

@simon04
Copy link
Author

simon04 commented Dec 2, 2020

Thank you for the instant fix! 😄

@vszakats
Copy link
Member

vszakats commented Dec 2, 2020

You're welcome! But, it didn't fix it; now the 32-bit version appears as zero size. Can't readily see what may be the problem...

One thing definitely changed in curl-for-win with 7.73.0_3: Now each .zip and .tar.xz file comes with a GPG signature with a .asc suffix in their filenames.

If the logic accidentally picks the .asc file instead of the archive, it may result in a zero size when rounded to MB.

So perhaps this is the fix:

diff --git a/windows/mkfiles.pl b/windows/mkfiles.pl
index 1dbece7..db2194f 100755
--- a/windows/mkfiles.pl
+++ b/windows/mkfiles.pl
@@ -95,7 +95,7 @@ my $dl = latest();
 my @files = getdl($dl);
 for(@files) {
     my $file = $_;
-    if($file =~ /^curl-([0-9.]*(|_[0-9]*))-(\S+)-(\S+)\.(zip)/) {
+    if($file =~ /^curl-([0-9.]*(|_[0-9]*))-(\S+)-(\S+)\.(zip)$/) {
         my ($version, $arch, $env, $ext)=($1, $3, $4, $5);
         $exts{$version}.="$ext,";
         $archs{$version.$ext}.="$arch,";

@vszakats
Copy link
Member

vszakats commented Dec 2, 2020

It looks like the fix worked for the latest pushed revision. Closing this for now. Thanks for the report!

@vszakats vszakats closed this as completed Dec 2, 2020
@bagder
Copy link
Member

bagder commented Dec 3, 2020

🎉

@vszakats vszakats changed the title curl-7.73.0_3-win64-mingw.zip has size 0.0 MB? curl-7.73.0_3-win64-mingw.zip has size 0.0 MB? Apr 24, 2021
@vszakats vszakats added the bug label Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants