Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTERNALS markdown parsing is wrong; or is right but looks wrong #19

Closed
jay opened this issue Oct 29, 2016 · 2 comments
Closed

INTERNALS markdown parsing is wrong; or is right but looks wrong #19

jay opened this issue Oct 29, 2016 · 2 comments

Comments

@jay
Copy link
Member

jay commented Oct 29, 2016

INTERNALS.md seems to look fine in markdown but the website version interprets the underscores as italic. I assume what is happening is somewhere the unwrapping occurs so it sees the two underscores on one line and turns it into italic? This has led to some text styled incorrect in the website version. AFAICS internals.t is basically a copy of INTERNALS.md, so I'm not sure how or why this is happening. A brute solution would be wrap code around every foo_bar but I wonder if there is something more correct I'm missing.
bagder added a commit to curl/curl that referenced this issue Oct 30, 2016
@bagder
INTERNALS: better markdown
13f4913 
words with underscore need to be within `these`

Bug: curl/curl-www#19
Reported-by : Jay Satiro
@bagder
Copy link
Member

bagder commented Oct 30, 2016 •
edited
Loading

The difference is simply because they use different markdown-to-HTML converters so the underscore confuses one but not the other. We should put those words within the necessary quotes. I had a got at it now.

@jay
Copy link
Member Author

jay commented Oct 31, 2016

Great. I noticed two more so I went through and wrapped a bunch more in curl/curl@164ee10.

@jay jay closed this as completed Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bagder @jay