Skip to content

Commit

Permalink
http2: fix variable type
Browse files Browse the repository at this point in the history
`max_recv_speed` is `curl_off_t`, so using `size_t` might result in
-Wconversion GCC warnings for 32-bit `size_t`. Visible in the NetBSD
ARM autobuilds.

Closes #11312
  • Loading branch information
MarcelRaad committed Jun 13, 2023
1 parent bc1e405 commit 1a42ecb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/http2.c
Expand Up @@ -1992,7 +1992,7 @@ static ssize_t h2_submit(struct stream_ctx **pstream,
* Let's limit our stream window size around that, otherwise the server
* will send in large bursts only. We make the window 50% larger to
* allow for data in flight and avoid stalling. */
size_t n = (((data->set.max_recv_speed - 1) / H2_CHUNK_SIZE) + 1);
curl_off_t n = (((data->set.max_recv_speed - 1) / H2_CHUNK_SIZE) + 1);
n += CURLMAX((n/2), 1);
if(n < (H2_STREAM_WINDOW_SIZE / H2_CHUNK_SIZE) &&
n < (UINT_MAX / H2_CHUNK_SIZE)) {
Expand Down

0 comments on commit 1a42ecb

Please sign in to comment.