Skip to content

Commit

Permalink
build: delete unused HAVE_{GSSHEIMDAL,GSSMIT,HEIMDAL}
Browse files Browse the repository at this point in the history
Stop setting `HAVE_GSSHEIMDAL`, `HAVE_GSSMIT` and `HAVE_HEIMDAL`.
There was no place in the build system or source code that used them.

Reviewed-by: Daniel Stenberg
Closes #12506
  • Loading branch information
vszakats committed Dec 16, 2023
1 parent ee6992c commit 423645a
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 53 deletions.
6 changes: 2 additions & 4 deletions CMakeLists.txt
Expand Up @@ -907,10 +907,8 @@ if(CURL_USE_GSSAPI)
check_include_file_concat("gssapi/gssapi_generic.h" HAVE_GSSAPI_GSSAPI_GENERIC_H)
check_include_file_concat("gssapi/gssapi_krb5.h" HAVE_GSSAPI_GSSAPI_KRB5_H)

if(GSS_FLAVOUR STREQUAL "Heimdal")
set(HAVE_GSSHEIMDAL ON)
else() # MIT
set(HAVE_GSSMIT ON)
if(NOT GSS_FLAVOUR STREQUAL "Heimdal")
# MIT
set(_INCLUDE_LIST "")
if(HAVE_GSSAPI_GSSAPI_H)
list(APPEND _INCLUDE_LIST "gssapi/gssapi.h")
Expand Down
6 changes: 1 addition & 5 deletions configure.ac
Expand Up @@ -1828,10 +1828,7 @@ AC_INCLUDES_DEFAULT
if test "x$not_mit" = "x1"; then
dnl MIT not found, check for Heimdal
AC_CHECK_HEADER(gssapi.h,
[
dnl found
AC_DEFINE(HAVE_GSSHEIMDAL, 1, [if you have Heimdal])
],
[],
[
dnl no header found, disabling GSS
want_gss=no
Expand All @@ -1840,7 +1837,6 @@ AC_INCLUDES_DEFAULT
)
else
dnl MIT found
AC_DEFINE(HAVE_GSSMIT, 1, [if you have MIT Kerberos])
dnl check if we have a really old MIT Kerberos version (<= 1.2)
AC_MSG_CHECKING([if GSS-API headers declare GSS_C_NT_HOSTBASED_SERVICE])
AC_COMPILE_IFELSE([
Expand Down
6 changes: 0 additions & 6 deletions lib/config-os400.h
Expand Up @@ -116,12 +116,6 @@
/* Define if you have the GNU gssapi libraries */
#undef HAVE_GSSGNU

/* Define if you have the Heimdal gssapi libraries */
#define HAVE_GSSHEIMDAL

/* Define if you have the MIT gssapi libraries */
#undef HAVE_GSSMIT

/* Define if you need the malloc.h header file even with stdlib.h */
/* #define NEED_MALLOC_H 1 */

Expand Down
6 changes: 0 additions & 6 deletions lib/curl_config.h.cmake
Expand Up @@ -298,12 +298,6 @@
/* if you have the GNU gssapi libraries */
#cmakedefine HAVE_GSSGNU 1

/* if you have the Heimdal gssapi libraries */
#cmakedefine HAVE_GSSHEIMDAL 1

/* if you have the MIT gssapi libraries */
#cmakedefine HAVE_GSSMIT 1

/* Define to 1 if you have the `idna_strerror' function. */
#cmakedefine HAVE_IDNA_STRERROR 1

Expand Down
32 changes: 0 additions & 32 deletions packages/vms/config_h.com
Expand Up @@ -1386,38 +1386,6 @@ $ write tf "#define ''key2' 1"
$ write tf "#endif"
$ goto cfgh_in_loop1
$ endif
$!
$! This is really do we have the newer MIT Kerberos
$!----------------------------------------------------------------------
$ if (key2 .eqs. "HAVE_GSSMIT")
$ then
$ if f$search(test_mit) .nes. ""
$ then
$ write tf "#ifndef ''key2'"
$ write tf "#define ''key2' 1"
$ else
$ write tf "#ifdef ''key2'"
$ write tf "#undef ''key2'"
$ endif
$ write tf "#endif"
$ goto cfgh_in_loop1
$ endif
$!
$! Older MIT looks like Heimdal
$!------------------------------------------------
$ if (key2 .eqs. "HAVE_HEIMDAL")
$ then
$ if f$search(test_mit) .eqs. ""
$ then
$ write tf "#ifndef ''key2'"
$ write tf "#define ''key2' 1"
$ else
$ write tf "#ifdef ''key2'"
$ write tf "#undef ''key2'"
$ endif
$ write tf "#endif"
$ goto cfgh_in_loop1
$ endif
$ endif
$!
$ endif
Expand Down

0 comments on commit 423645a

Please sign in to comment.