Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
configure: if asked to use TLS, fail if no TLS lib was detected
Previously the configure script would just warn about this fact and continue with TLS disabled build which is not always helpful. TLS should be explicitly disabled if that is what the user wants. Closes #9367
- Loading branch information
Showing
1 changed file
with
8 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
576e507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something seems to be wrong here. The 3 msys2-based autotools builds on AppVeyor all use
--with-schannel
but fail with:Example: https://ci.appveyor.com/project/curlorg/curl/builds/44579697/job/30mp02ugtv77fpm4#L229
576e507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, those 3 builds could have never used Schannel as they are msys2-native and not Win32-based.
576e507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, then they rather proved that the change was good! 😄
576e507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello.
This commit breaks cross-compilation of curl (libcurl) under Mingw64 in Ubuntu with target Win10x64.
Cross-compiling with the previous commit of curl works fine.
Both rely on gnutls 3.7.7.
Logs attached.
Extract from config.log:
2_config.log
1_visible_log.txt
576e507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hydra3333 if you have an issue, then please submit an issue and not just a comment on a commit.
This particular change was in configure logic only, so it seems unlikely that this particular commit broke the build in the way you describe.
576e507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Will create an issue.
@bagder I just re-tried and observe that the prior commit definitely cross-compiles fine whereas this commit definitely does not, with nothing else being changed.
576e507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's figure out why!
576e507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you are sure your build previously simply didn't just build without TLS? Because your configure build fails to detect GnuTLS and this change didn't affect that detection, it only made the failure a fatal error.
576e507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bagder yes I'm sure ... I think ... only on the basis of going back and forth with the same configure just a change in the commit used.
576e507
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please comment in the issue