Skip to content

Commit

Permalink
Fix perl segfault due to changes in header callback behaviour since c…
Browse files Browse the repository at this point in the history
…url-7.8.1-pre3
  • Loading branch information
Cris Bailiff committed Sep 10, 2001
1 parent 3f5227d commit 96c7253
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 6 deletions.
4 changes: 4 additions & 0 deletions perl/Curl_easy/Changes
@@ -1,6 +1,10 @@
Revision history for Perl extension Curl::easy.
Check out the file README for more info.

1.1.6 Mon Sep 10 2001: - Cris Bailiff <c.bailiff@devsecure.com>
- Fix segfault due to changes in header callback behaviour
since curl-7.8.1-pre3

1.1.5 Fri Apr 20 2001: - Cris Bailiff <c.bailiff@devsecure.com>
- Add latest CURLOPT_ and CURLINFO_ constants to the constants list

Expand Down
4 changes: 2 additions & 2 deletions perl/Curl_easy/easy.pm
Expand Up @@ -110,7 +110,7 @@ CURLINFO_CONTENT_LENGTH_UPLOAD
USE_INTERNAL_VARS
);

$VERSION = '1.1.5';
$VERSION = '1.1.6';

$Curl::easy::headers = "";
$Curl::easy::content = "";
Expand Down Expand Up @@ -254,7 +254,7 @@ indicate an error.
Georg Horn <horn@koblenz-net.de>
Additional callback,pod and tes work by Cris Bailiff <c.bailiff@devsecure.com>
Additional callback,pod and test work by Cris Bailiff <c.bailiff@devsecure.com>
and Forrest Cahoon <forrest.cahoon@merrillcorp.com>
=head1 SEE ALSO
Expand Down
15 changes: 11 additions & 4 deletions perl/Curl_easy/easy.xs
Expand Up @@ -101,12 +101,14 @@ fwrite_wrapper (const void *ptr,

if (stream == stdout) {
sv = newSViv(0); /* FIXME: should cast stdout to GLOB somehow? */
} else { /* its already an SV */
} else if (stream == NULL) {
sv = &PL_sv_undef;
} else { /* its already an SV */
sv = stream;
}

if (ptr != NULL) {
XPUSHs(sv_2mortal(newSVpvn(ptr, size * nmemb)));
XPUSHs(sv_2mortal(newSVpvn((char *)ptr, (STRLEN)(size * nmemb))));
} else {
XPUSHs(sv_2mortal(newSVpv("", 0)));
}
Expand All @@ -130,15 +132,20 @@ fwrite_wrapper (const void *ptr,
} else {
/* default to a normal 'fwrite' */
/* stream could be a FILE * or an SV * */
/* or NULL since libcurl-7.8.1pre3 */
FILE *f;

if (stream == stdout) { /* the only possible FILE ? Think so */
if (stream == stdout ||
stream == NULL) { /* the only possible FILE ? Think so */
f = stream;
} else { /* its a GLOB */
f = IoIFP(sv_2io(stream)); /* may barf if not a GLOB */
}

return fwrite(ptr, size, nmemb, f);
if (f)
return fwrite(ptr, size, nmemb, f);
else
return (size_t) size*nmemb;
}
}

Expand Down

0 comments on commit 96c7253

Please sign in to comment.