Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tool_parsecfg: make warning output propose double-quoting
When the config file parser detects a word that *probably* should be quoted, mention double-quotes as a possible remedy. Test 459 verifies. Proposed-by: Jiehong on github Fixes #12409 Closes #12412
- Loading branch information
Showing
3 changed files
with
66 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
<testcase> | ||
<info> | ||
<keywords> | ||
HTTP | ||
--config | ||
</keywords> | ||
</info> | ||
|
||
# | ||
# Server-side | ||
<reply> | ||
<data crlf="yes"> | ||
HTTP/1.1 200 OK | ||
Date: Tue, 09 Nov 2010 14:49:00 GMT | ||
Server: test-server/fake | ||
Last-Modified: Tue, 13 Jun 2000 12:10:00 GMT | ||
ETag: "21025-dc7-39462498" | ||
Accept-Ranges: bytes | ||
Content-Length: 6 | ||
Connection: close | ||
Content-Type: text/html | ||
Funny-head: yesyes | ||
|
||
-foo- | ||
</data> | ||
</reply> | ||
|
||
# | ||
# Client-side | ||
<client> | ||
<server> | ||
http | ||
</server> | ||
<name> | ||
config file with argument using whitespace missing quotes | ||
</name> | ||
<file name="%LOGDIR/config"> | ||
data = arg with space | ||
</file> | ||
<command> | ||
http://%HOSTIP:%HTTPPORT/%TESTNUMBER --config %LOGDIR/config --silent | ||
</command> | ||
</client> | ||
|
||
# | ||
# Verify data after the test has been "shot" | ||
<verify> | ||
<protocol crlf="yes" nonewline="yes"> | ||
POST /%TESTNUMBER HTTP/1.1 | ||
Host: %HOSTIP:%HTTPPORT | ||
User-Agent: curl/%VERSION | ||
Accept: */* | ||
Content-Length: 3 | ||
Content-Type: application/x-www-form-urlencoded | ||
|
||
arg | ||
</protocol> | ||
<stderr mode="text"> | ||
Warning: log/config:1: warning: 'data' uses unquoted whitespace that may cause | ||
Warning: side-effects. Consider quoting the value with double quotes? | ||
</stderr> | ||
</verify> | ||
</testcase> |