conn: always set bits.close with connclose()

Closes #4690
curl · Dec 9, 2019 · c7bc689 · c7bc689
1 parent 35c7aac
commit c7bc689
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/http_proxy.c b/lib/http_proxy.c
@@ -58,8 +58,9 @@ static CURLcode https_proxy_connect(struct connectdata *conn, int sockindex)
       Curl_ssl_connect_nonblocking(conn, sockindex,
                                    &conn->bits.proxy_ssl_connected[sockindex]);
     if(result)
-      conn->bits.close = TRUE; /* a failed connection is marked for closure to
-                                  prevent (bad) re-use or similar */
+      /* a failed connection is marked for closure to prevent (bad) re-use or
+         similar */
+      connclose(conn, "TLS handshake failed");
   }
   return result;
 #else

diff --git a/lib/multi.c b/lib/multi.c
@@ -639,7 +639,7 @@ static CURLcode multi_done(struct Curl_easy *data,
      ) || conn->bits.close
        || (premature && !(conn->handler->flags & PROTOPT_STREAM))) {
     CURLcode res2;
-    conn->bits.close = TRUE; /* forcibly prevents reuse */
+    connclose(conn, "disconnecting");
     CONN_UNLOCK(data);
     res2 = Curl_disconnect(data, conn, premature);