url: always clone the CUROPT_CURLU handle

Since a few code paths actually update that data. Fixes #3753 Reported-by: Poul T Lomholt
curl · Apr 11, 2019 · e2caf80 · e2caf80
1 parent 06ace0b
commit e2caf80
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/url.c b/lib/url.c
@@ -303,8 +303,7 @@ static void up_free(struct Curl_easy *data)
   Curl_safefree(up->options);
   Curl_safefree(up->path);
   Curl_safefree(up->query);
-  if(data->set.uh != data->state.uh)
-    curl_url_cleanup(data->state.uh);
+  curl_url_cleanup(data->state.uh);
   data->state.uh = NULL;
 }
 
@@ -1879,7 +1878,7 @@ static CURLcode parseurlandfillconn(struct Curl_easy *data,
 
   /* parse the URL */
   if(data->set.uh) {
-    uh = data->state.uh = data->set.uh;
+    uh = data->state.uh = curl_url_dup(data->set.uh);
   }
   else {
     uh = data->state.uh = curl_url();