Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 2600 failures under load #11355

Closed
dfandrich opened this issue Jun 20, 2023 · 2 comments
Closed

Test 2600 failures under load #11355

dfandrich opened this issue Jun 20, 2023 · 2 comments
Assignees
@icing
Labels
connecting & proxies tests

Comments

@dfandrich
Copy link
Contributor

A recent CI test run with parallel testing enabled produced some test 2600 failures on GHA on Linux. The two types of failures were:

 unit2600.c:253 test failed: '1: expected 1 ipv4 creations, but got 0'
 unit2600.c:272 test failed: '1: expected max duration of 600ms, but took 701ms'

The test seems to be timing sensitive, so maybe the timeouts just need to be increased (especially for that second failure), but without digging in to the test I'm not sure if a bad timeout would cause the first failure, too. Here are the failing logs from that run:
icing added a commit to icing/curl that referenced this issue Aug 18, 2023
@icing
Test2600, fix flakiness on low cpu
81d6df4 
- refs curl#11355 where failures to to low cpu resources in CI
  are reported
- vastly extend CURLOPT_CONNECTTIMEOUT_MS and max durations
  to test cases
- trigger Curl_expire() in test filter to allow re-checks before
  the usual 1second interval
@icing icing mentioned this issue Aug 18, 2023
Closed
@icing
Copy link
Contributor

icing commented Aug 18, 2023

Sometimes it takes longer. See #11690 for an attempt to address this.

bagder pushed a commit that referenced this issue Aug 21, 2023
@icing @bagder
test2600: fix flakiness on low cpu
8627416 
- refs #11355 where failures to to low cpu resources in CI
  are reported
- vastly extend CURLOPT_CONNECTTIMEOUT_MS and max durations
  to test cases
- trigger Curl_expire() in test filter to allow re-checks before
  the usual 1second interval

Closes #11690
ptitSeb pushed a commit to wasix-org/curl that referenced this issue Sep 25, 2023
@icing @ptitSeb
test2600: fix flakiness on low cpu
ea8c371 
- refs curl#11355 where failures to to low cpu resources in CI
  are reported
- vastly extend CURLOPT_CONNECTTIMEOUT_MS and max durations
  to test cases
- trigger Curl_expire() in test filter to allow re-checks before
  the usual 1second interval

Closes curl#11690
@bagder
Copy link
Member

bagder commented Nov 30, 2023

@dfandrich I don't think I have seen many test 2600 failures lately. Is this issue still valid?

@bagder bagder closed this as completed Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icing icing

Labels
connecting & proxies tests
Milestone
No milestone
Development

No branches or pull requests
3 participants
@icing @bagder @dfandrich