--haproxy-clientip sets destination IP, not client IP

[bagder]

Discussed in #11613

^{Originally posted by marsom August 7, 2023}
Hi,

ok I'm probably wrong, I expected the from following curl:

curl --ipv4 --haproxy-clientip 192.168.1.2 http://localhost:8080

to set the client ip in the proxy protocol header to 192.168.1.2. in the proxy protocol naming for me its the source ip not the destination.

but

curl/lib/cf-haproxy.c

Line 91 in 78d6232

result = Curl_dyn_addf(&ctx->data_out, "PROXY %s %s %s %i %i\r\n",

sets the destination address.

when i read ie.

• https://developers.cloudflare.com/spectrum/how-to/enable-proxy-protocol/#the-proxy-protocol-v1-header
• https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/enable-proxy-protocol.html
• https://community.f5.com/t5/codeshare/proxy-protocol-initiator/ta-p/280541

i think the client ip = source ip

if I dump the payload from the command obove i get

PROXY TCP4 127.0.0.1 192.168.1.2 62190 8080
GET / HTTP/1.1
Host: localhost:8080
User-Agent: curl/8.2.1
Accept: */*
...

[bagder]

/cc @RaitoBezarius

[RaitoBezarius]

Apologies for this and thank you @bagder — you were faster than me to fix it… :)