Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.63.0 - OS400 build fails in os400sys.c/ccsidcurl.c #3453

Closed
jonrumsey opened this issue Jan 10, 2019 · 8 comments

Comments

@jonrumsey
Copy link

commented Jan 10, 2019

I did this

Attempted to build 7.63.0 on OS400, fails with the following errors in curl_url_get_ccsid() packages/OS400/ccsidcurl.c

*part = dynconvert(ccsid, s, -1, ccsid, ASCII_CCSID);
*=SEVERE==========> a - CZM0099 Unexpected argument.

Looks like this was added in a77b640, I think the code should be;

*part = dynconvert(ccsid, s, -1, ASCII_CCSID);

I expected the following

Clean build

curl/libcurl version

[curl -V output]

operating system

OS400 V7R2M0

@bagder

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

ping @monnerat

@bagder bagder added the build label Jan 10, 2019

@danielgustafsson

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@monnerat

This comment has been minimized.

Copy link
Collaborator

commented Jan 10, 2019

Yes, you're right: thanks for testing.
I will fix it in a few minutes.

@jonrumsey

This comment has been minimized.

Copy link
Author

commented Jan 10, 2019

Thanks for the quick response, I think there is also a right bracket missing to complete this if statement on line 1442;

if(result == CURLUE_OK) {

@monnerat monnerat closed this in adf39fb Jan 10, 2019

@danielgustafsson

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

monnerat added a commit that referenced this issue Jan 10, 2019
os400: add a missing closing bracket
See #3453 (comment)

Reported-by: jonrumsey on github
@monnerat

This comment has been minimized.

Copy link
Collaborator

commented Jan 10, 2019

I think there is also a right bracket missing to complete this if statement on line 1442;

Thanks again for reporting: fixed in 30ac449.
As you may know, I do not have access to an OS400 anymore and can only perform a very imperfect "optical" check on changes for this platform. Thus I appreciate your testing and reporting :-)

@danielgustafsson

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@jonrumsey

This comment has been minimized.

Copy link
Author

commented Jan 10, 2019

No problem, really appreciate the quick responses.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.