7.63.0 - OS400 build fails in os400sys.c/ccsidcurl.c

[jonrumsey]

I did this

Attempted to build 7.63.0 on OS400, fails with the following errors in curl_url_get_ccsid() packages/OS400/ccsidcurl.c

*part = dynconvert(ccsid, s, -1, ccsid, ASCII_CCSID);
*=SEVERE==========> a - CZM0099 Unexpected argument.

Looks like this was added in a77b640, I think the code should be;

*part = dynconvert(ccsid, s, -1, ASCII_CCSID);

I expected the following

Clean build

curl/libcurl version

[curl -V output]

operating system

OS400 V7R2M0

[bagder]

ping @monnerat

[danielgustafsson]

On 10 Jan 2019, at 11:33, jonrumsey ***@***.***> wrote: I did this Attempted to build 7.63.0 on OS400, fails with the following errors in curl_url_get_ccsid() packages/OS400/ccsidcurl.c *part = dynconvert(ccsid, s, -1, ccsid, ASCII_CCSID); *=SEVERE==========> a - CZM0099 Unexpected argument. Looks like this was added in a77b640, I think the code should be; *part = dynconvert(ccsid, s, -1, ASCII_CCSID);

Agreed, judging by the function prototype this seems like a correct conclusion.

[monnerat]

Yes, you're right: thanks for testing.
I will fix it in a few minutes.

[jonrumsey]

Thanks for the quick response, I think there is also a right bracket missing to complete this if statement on line 1442;

if(result == CURLUE_OK) {

[danielgustafsson]

On 10 Jan 2019, at 11:54, jonrumsey ***@***.***> wrote: Thanks for the quick response, I think there is also a right bracket missing to complete this if statement on line 1442; if(result == CURLUE_OK) {

To my reading, thats correct again.

[monnerat]

I think there is also a right bracket missing to complete this if statement on line 1442;

Thanks again for reporting: fixed in 30ac449.
As you may know, I do not have access to an OS400 anymore and can only perform a very imperfect "optical" check on changes for this platform. Thus I appreciate your testing and reporting :-)

[danielgustafsson]

On 10 Jan 2019, at 12:21, monnerat ***@***.***> wrote: I think there is also a right bracket missing to complete this if statement on line 1442; Thanks again for reporting: fixed in 30ac449 <30ac449>. As you may know, I do not have access to an OS400 anymore and can only perform a very imperfect "optical" check on changes for this platform. Thus I appreciate your testing and reporting :-)

Seconded, much appreciated!

[jonrumsey]

No problem, really appreciate the quick responses.