Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcurl 7.65.0 does not build with --disable-ftp (without also having --disable-file) #3924

Closed
thomgree opened this issue May 22, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@thomgree
Copy link

commented May 22, 2019

Looks like this was introduced here:
e91e481
(should have been #ifndef CURL_DISABLE_FTP not #ifndef CURL_DISABLE_FILE)

bagder added a commit that referenced this issue May 22, 2019

url: fix bad #ifdef
Regression since e91e481.

Reported-by: Tom Greenslade
Fixes #3924

@bagder bagder closed this in dc0a671 May 23, 2019

@michael-o

This comment has been minimized.

Copy link
Member

commented May 27, 2019

I can confirm this on HP-UX:

# gmake
Making all in lib
gmake[1]: Entering directory '/tmp/system-compile/curl/curl-7.65.0/lib'
gmake  all-am
gmake[2]: Entering directory '/tmp/system-compile/curl/curl-7.65.0/lib'
  CC       libcurl_la-url.lo
"url.c", line 443: error #2136: struct "UserDefined" has no field
          "ftp_use_epsv"
    set->ftp_use_epsv = TRUE;   /* FTP defaults to EPSV operations */
         ^

"url.c", line 444: error #2136: struct "UserDefined" has no field
          "ftp_use_eprt"
    set->ftp_use_eprt = TRUE;   /* FTP defaults to EPRT operations */
         ^

"url.c", line 445: error #2136: struct "UserDefined" has no field
          "ftp_use_pret"
    set->ftp_use_pret = FALSE;  /* mainly useful for drftpd servers */
         ^

"url.c", line 446: error #2136: struct "UserDefined" has no field
          "ftp_filemethod"
    set->ftp_filemethod = FTPFILE_MULTICWD;
         ^

4 errors detected in the compilation of "url.c".
gmake[2]: *** [Makefile:1630: libcurl_la-url.lo] Error 1
gmake[2]: Leaving directory '/tmp/system-compile/curl/curl-7.65.0/lib'
gmake[1]: *** [Makefile:1024: all] Error 2
gmake[1]: Leaving directory '/tmp/system-compile/curl/curl-7.65.0/lib'
gmake: *** [Makefile:923: all-recursive] Error 1

I will fix this inline, but this should be probably shipped with 7.65.1 soon.

CamJN added a commit to phusion/passenger_binary_build_automation that referenced this issue May 28, 2019

Allow curl to build
file:// disabled due to curl/curl#3924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.