Inconsistent brotli package name in CMake #4117
Closed
Labels
Comments
Thanks |
caraitto
added a commit
to caraitto/curl
that referenced
this issue
Jul 23, 2019
- Find package "Brotli" instead of "BROTLI" since the former is the casing used for CMake/FindBrotli.cmake, and otherwise find_package may fail on a case-sensitive file system. Fixes curl#4117
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It seems that brotli package name is inconsistent in cmake files.
CMakeLists.txt contains string find_package(BROTLI QUIET)
but there is a file CMake/FindBrotli.cmake
It seems that either CMake/FindBrotli.cmake should be renamed to CMake/FindBROTLI.cmake or find_package(BROTLI QUIET) should be replaced with find_package(Brotli QUIET)
Otherwise find_package fails to find brotli on Linux machine with the following message:
The text was updated successfully, but these errors were encountered: