Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
'Error in the HTTP2 framing layer' after goaway #4267
I did this
A request to a HTTP/2 server that was restarting resulted in a "Error in the HTTP2 framing layer" message despite the server behaving correctly. Further investigation shows that in the case of a GOAWAY frame with a fully processed 204 "No content" response the GOAWAY wins and an error is returned.
I expected the following
Since the response was received in its entirety, there should be no error. The connection should then be closed (since there was a GOAWAY frame).
steps to reproduce
I have this little Go program that runs a webserver to return a 204 while also sending a goaway frame: https://gist.github.com/TvdW/4d12fc00f91175e379b15a079319d000 (running as
For simplicity, I also have it running at https://domisc-01.server.tvdw.eu/
It could otherwise return an error even when closed correctly if GOAWAY had been received previously. Reported-by: Tom van der Woerdt Fixes #4267