Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtcp2 C++ example build failure on travis #4637

bagder opened this issue Nov 26, 2019 · 0 comments

ngtcp2 C++ example build failure on travis #4637

bagder opened this issue Nov 26, 2019 · 0 comments


Copy link

bagder commented Nov 26, 2019

I did this

I noticed build failures on travis on current ngtcp2 builds. They build ngtcp2 from their git master and the failure is in the building of their example client.

In file included from
client.h:35:23: fatal error: string_view: No such file or directory
compilation terminated.
Makefile:719: recipe for target 'client.o' failed
make[2]: *** [client.o] Error 1

I expected the following

The build to go green


I asked @tatsuhiro-t about it in another channel and he responded like this:

It is in C++17 standard. Recent gcc/clang should work. I'll add configure option to build library only.

We can work on fixing the C++ in travis or just disable the example build for ngtcp2 (once support for that has landed). Disabling the example will be preferably anyway since it'll speed up the build and we don't use the example for anything!

@bagder bagder added the build label Nov 26, 2019
bagder added a commit that referenced this issue Nov 26, 2019
@bagder bagder closed this as completed in 113db12 Nov 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Successfully merging a pull request may close this issue.

1 participant