Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngtcp2_crypto_read_write_crypto_data() causes error in build #5444

Closed
xquery opened this issue May 24, 2020 · 2 comments
Closed

ngtcp2_crypto_read_write_crypto_data() causes error in build #5444

xquery opened this issue May 24, 2020 · 2 comments
Labels

Comments

@xquery
Copy link
Member

@xquery xquery commented May 24, 2020

func signature in ngtcp2 has changed which causes curl build (when building in ngtcp2 support) to fail.

vquic/ngtcp2.c:617:6: error: too many arguments to function ‘ngtcp2_crypto_read_write_crypto_data’
if(ngtcp2_crypto_read_write_crypto_data(tconn, qs->ssl, crypto_level, data,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

guessing the fix is updating func invoke in vquic/ngtcp2.c

@xquery xquery changed the title latest ngtcp2_crypto_read_write_crypto_data causes error in build ngtcp2_crypto_read_write_crypto_data() causes error in build May 24, 2020
@xquery
Copy link
Member Author

@xquery xquery commented May 24, 2020

this is the relevant recent commit to ngtcp2

ngtcp2/ngtcp2@15833a1

@Lekensteyn
Copy link
Member

@Lekensteyn Lekensteyn commented May 24, 2020

This will be fixed by PR #5443.

@Lekensteyn Lekensteyn added the HTTP/3 label May 24, 2020
Lekensteyn added a commit to Lekensteyn/curl that referenced this issue May 24, 2020
Based on client.cc changes from ngtcp2. Tested with current git master,
ngtcp2 commit c77d5731ce92, nghttp3 commit 65ff479d4380.

Fixes curl#5444
Closes curl#5443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.