Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHTTP header fields stored per connection causes problems #5566
Assignees
Labels
Comments
bagder
added a commit
that referenced
this issue
Jun 15, 2020
Since the connection can be used by many independent requests (using HTTP/2 or HTTP/3), things like user-agent and other transfer-specific data MUST NOT be kept connection oriented as it could lead to requests getting the wrong string for their requests. This struct data was lingering like this due to old HTTP1 legacy thinking where it didn't mattered.. Fixes #5566
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
struct dynamically_allocated_datais stored within theconnectdatastruct. That data is then used per connection, while all the data in that struct is actually per request. A mistake.This causes (occasional) problems for multiplexed requests as then the same connection is used for multiple (independent) requests that could have a different setup of that data.
Solution: move that data to the per-request struct held in the
Curl_easystruct.