Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty proxy password is sent to server as '(nil)' #5613

Closed
kristofg opened this issue Jun 26, 2020 · 0 comments
Closed

Empty proxy password is sent to server as '(nil)' #5613

kristofg opened this issue Jun 26, 2020 · 0 comments

Comments

@kristofg
Copy link

@kristofg kristofg commented Jun 26, 2020

I did this

Scenario is the same as #5601: We're doing proxy authentication using basic auth, username "proxyuser" and an empty password. This works fine for us on 7.70.0, but breaks when upgrading to 7.71.0. Looking at the debug logs we see the following when responding to the proxy 407:

[header OUT] Proxy-Authorization: Basic cHJveHl1c2VyOihuaWwp

The base64 part decodes to proxyuser:(nil), which doesn't look right.

Looking at the code it's tempting to suspect that this (nil) string originates from dprintf_formatf, possibly coming down from this printf?

curl/libcurl version

7.71.0

operating system

Linux

@bagder bagder self-assigned this Jun 26, 2020
bagder added a commit that referenced this issue Jun 26, 2020
Regression in 7.71.0

Added test case 346 to verify.

Reported-by: Kristoffer Gleditsch
Fixes #5613
@bagder bagder closed this in ff43fb6 Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.