Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
FTP uploading not reporting CURLE_REMOTE_DISK_FULL #6016
I did this
I used libcurl to upload a file to an FTP server, unfortunately I don't know what server it is. The server had exhausted the disk quota and after the STOR command the server returned a 552 error, which is appears to have been standardizes as meaning "disk full". Searching for "ftp 552" suggests it is widely supported.
Another FTP client (Transmit) reports the following:
I thought this error might have been an interpretation on the client side so I used wireshark and actually saw the server responding 552:
Response: 552 STOR: notice: quota reached: 'test.mp4' removed
I expected the following
I expected libcurl to return CURLE_REMOTE_DISK_FULL, instead libcurl reports CURLE_PARTIAL_FILE, which is not incorrect but is less specific, particularly when it comes to offering actionable information to the user.
We build libcurl ourselves, 7.72.0
Added test 348 to verify. Added a 'STOR' command to the test FTP server to enable test 348. Documented the command in FILEFORMAT.md Reported-by: Duncan Wilcox Fixes #6016