Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: location ambiguities #7444

Closed
jsoref opened this issue Jul 19, 2021 · 0 comments
Closed

docs: location ambiguities #7444

jsoref opened this issue Jul 19, 2021 · 0 comments

Comments

@jsoref
Copy link
Contributor

jsoref commented Jul 19, 2021

When curl follows a redirect and if the request is a POST, it will do the
following request with a GET if the HTTP response was 301, 302, or 303. If the
response code was any other 3xx code, curl will re-send the following request
using the same unmodified method.

do -> send/repeat (send seems like the right choice since it corresponds to the later usage in the text)
following -> following/subsequent/replacement/related

-When curl follows a redirect and if the request is a POST, it will do the 
+When curl follows a redirect and if the request is a POST, it will send the 
 following request with a GET if the HTTP response was 301, 302, or 303. If the 
 response code was any other 3xx code, curl will re-send the following request 
 using the same unmodified method. 

The end of the paragraph doesn't clearly highlight that for any non-POST request and any POST request with any other 3xx code it's retransmitted otherwise (i.e. other than the location) unmodified. Partially this is because the paragraph's introductory sentence focuses on POST. I can't really explain just how confusing this can be.

(I've spent the last month or so reading posts to https://github.community and can attest to how easily readers can be confused by slightly unclear text.)

jay pushed a commit to jay/curl that referenced this issue Jul 26, 2021
@jay jay mentioned this issue Jul 26, 2021
@jay jay closed this as completed in 4d14534 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants