Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infof format strings shouldn't end with \n #7879

Closed
billionai opened this issue Oct 19, 2021 · 0 comments
Closed

infof format strings shouldn't end with \n #7879

billionai opened this issue Oct 19, 2021 · 0 comments
Assignees
@bagder
Labels
SSL/TLS

Comments

@billionai
Copy link

@billionai billionai commented Oct 19, 2021

Commit e7416cf removed \n from almost all infof calls, but the following call still has it

curl/lib/vtls/nss.c

Line 958 in 12246ed

infof(data, "subject: %s\n", subject);

@bagder bagder self-assigned this Oct 19, 2021
@bagder bagder added the SSL/TLS label Oct 19, 2021
bagder added a commit that referenced this issue Oct 19, 2021
@bagder
nss: remove newline from infof() call
092a52a 
Follow-up to e7416cf

Reported-by: billionai on github
Fixes #7879
@bagder bagder mentioned this issue Oct 19, 2021
Closed
@bagder bagder closed this in 54aa9c4 Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
SSL/TLS
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

nss: remove newline from infof() call
2 participants
@bagder @billionai