Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crypt32.lib to Visual Studio project template files #854

Closed
wants to merge 1 commit into from

Conversation

JDepooter
Copy link
Contributor

Similar to #849, this pull request fixes the generated Visual Studio project files. They now link in crypt32.lib when libcurl is built with schannel. This is required following #822.

@mback2k
Copy link
Member

mback2k commented Jun 2, 2016

Maybe the schannel.c code could be updated to check for crypt32.lib instead of requiring it per default, similar to https://github.com/libssh2/libssh2/blob/master/src/wincng.c#L54.

@bagder bagder added the build label Jun 4, 2016
@mback2k
Copy link
Member

mback2k commented Jun 12, 2016

@captain-caveman2k Would you mind taking a look at this pull-request? I think it is fine, besides my previous comment which will mainly affect the autotools-based builds.

@captain-caveman2k
Copy link
Contributor

No problem @mback2k.

Do you think it is better to try and use the #pragma fix instead like libssh2 does?

@mback2k
Copy link
Member

mback2k commented Jun 16, 2016

@captain-caveman2k It might be, but I think for curl it would probably be more logical to use the same consistent approach as for other libraries. If we were to use the #pragma fix then we should probably move all linked libraries to that approach. What do you think?

@bagder bagder closed this in 66c447e Jun 22, 2016
@bagder
Copy link
Member

bagder commented Jun 22, 2016

We can't wait anymore for the fix. I merged this and if we want it improved, we can do that from here.

@mback2k
Copy link
Member

mback2k commented Jun 22, 2016

Thanks @bagder. But I am still wondering how it worked for Win CE before, because the specific parts for that platform already used crypt32 functions:

if(!CertGetCertificateChain(NULL,

@bagder
Copy link
Member

bagder commented Jun 22, 2016

The Win CE users have always had a busload of various 3rd party additions and necessary "hacks" to build and run curl so maybe they just also then added that lib. It wouldn't surprise me.

@JDepooter JDepooter deleted the crypt32_build_fix branch August 22, 2016 21:58
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants