Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake doesn't check for _Atomic #8973

Closed
bagder opened this issue Jun 7, 2022 · 1 comment
Closed

cmake doesn't check for _Atomic #8973

bagder opened this issue Jun 7, 2022 · 1 comment
Labels
cmake help wanted KNOWN_BUGS material

Comments

@bagder
Copy link
Member

bagder commented Jun 7, 2022

Starting with #8680, libcurl has a thread-safe curl_global_init on most platforms iff using _Atomic works and gets used. Currently, the cmake build does not check for this symbol, which makes is unfortunate and therefore cannot build the init function thread-safe on several platforms!
@bagder bagder added the cmake label Jun 7, 2022
@bagder
Copy link
Member Author

bagder commented Jun 8, 2022 •
edited
Loading

This also makes test 1014 fail, at least on Appveyor: curl-config (when built with cmake) doesn't know about threadsafe-init

cblichmann added a commit to cblichmann/curl that referenced this issue Jun 8, 2022
@cblichmann
cmake: Check for C11 atomics and set config
6c6d927 
Context curl#8973
@cblichmann cblichmann mentioned this issue Jun 8, 2022
Closed
cblichmann added a commit to cblichmann/curl that referenced this issue Jun 8, 2022
@cblichmann
cmake: Check for C11 atomics and set config
286ceb0 
Context curl#8973

Also add `threadsafe-init` feature to list.
cblichmann added a commit to cblichmann/curl that referenced this issue Jun 8, 2022
@cblichmann
cmake: Check for C11 atomics and set config
01e2207 
Context curl#8973

- Also add `threadsafe-init` feature to list.
- Update the `AC_LANG_PROGRAM` to perform the same check as the CMake
  version
eaaltonen added a commit to eaaltonen/curl that referenced this issue Jun 8, 2022
@eaaltonen
Test for _Atomic in CMake build & set HAVE_ATOMIC
275eb22 
Fixes curl#8973
cblichmann added a commit to cblichmann/curl that referenced this issue Jun 10, 2022
@cblichmann
cmake: Check for C11 atomics and set config
6b7333e 
Context curl#8973

- Also add `threadsafe-init` feature to list.
- Update the `AC_LANG_PROGRAM` to perform the same check as the CMake
  version
cblichmann added a commit to cblichmann/curl that referenced this issue Jun 13, 2022
@cblichmann
cmake: Check for C11 atomics and set config
037c49a 
Context curl#8973

- Also add `threadsafe-init` feature to list.
- Update the `AC_LANG_PROGRAM` to perform the same check as the CMake
  version
cblichmann added a commit to cblichmann/curl that referenced this issue Jun 14, 2022
@cblichmann
cmake: Check for C11 atomics and set config
29d5da8 
Context curl#8973

- Also add `threadsafe-init` feature to list.
- Update the `AC_LANG_PROGRAM` to perform the same check as the CMake
  version
cblichmann added a commit to cblichmann/curl that referenced this issue Jun 15, 2022
@cblichmann
cmake: Check for C11 atomics and set config
15fd0a2 
Context curl#8973

- Also add `threadsafe` feature to list.
- Update the `AC_LANG_PROGRAM` to perform the same check as the CMake
  version
@bagder bagder closed this as completed in ba2ccf3 Aug 8, 2022
jquepi pushed a commit to jquepi/curl.1.555 that referenced this issue Oct 24, 2022
@bagder @jquepi
KNOWN_BUGS: cmake build is not thread-safe
d647b9f 
The cmake build does not check for and verify presence of a working
Atomic type, which then makes curl_global_init() to not build
thread-safe on non-Windows platforms.

Closes curl/curl#8973
Closes curl/curl#8982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmake help wanted KNOWN_BUGS material
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bagder