Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10-at-a-time example skips result of the last url in single MAX_PARALLEL mode #9953

Closed
kuznetsov-m opened this issue Nov 21, 2022 · 2 comments
Closed

10-at-a-time example skips result of the last url in single MAX_PARALLEL mode #9953

kuznetsov-m opened this issue Nov 21, 2022 · 2 comments
Labels
documentation

Comments

@kuznetsov-m
Copy link

kuznetsov-m commented Nov 21, 2022 •
edited
Loading

I did this

Take 10-at-a-time.c example and change next:

  • MAX_PARALLEL new value is 1
  • urls - left 3 items

then build and run.

I expected the following

R: 0 - No error <https://www.microsoft.com>
R: 0 - No error <https://opensource.org>
R: 0 - No error <https://www.google.com>

I received the following

R: 0 - No error <https://www.microsoft.com>
R: 0 - No error <https://opensource.org>

result of last url has been skipped.

operating system

Darwin MBP.local 20.6.0 Darwin Kernel Version 20.6.0: Mon Aug 30 06:12:21 PDT 2021; root:xnu-7195.141.6~3/RELEASE_X86_64 x86_64
jay added a commit to jay/curl that referenced this issue Nov 21, 2022
@jay
examples/10-at-a-time: fix possible skipped final transfers
99070d9 
Prior to this change if curl_multi_perform returned 0 running handles
and then all remaining transfers were added, then the perform loop would
end immediately without performing those transfers.

Reported-by: Mikhail Kuznetsov

Fixes curl#9953
Closes #xxxx
@jay jay mentioned this issue Nov 21, 2022
Closed
@jay
Copy link
Member

jay commented Nov 21, 2022

Please try #9953

@kuznetsov-m
Copy link
Author

Yes, it works! Alternative fix also looks great! Many thanks for the quick fix!

@jay jay closed this as completed in a28a80d Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

examples/10-at-a-time: fix possible skipped final transfers jay/curl
2 participants
@jay @kuznetsov-m