tool_formparse: avoid clobbering on function params#10046
Closed
danielgustafsson wants to merge 1 commit intocurl:masterfrom
Closed
tool_formparse: avoid clobbering on function params#10046danielgustafsson wants to merge 1 commit intocurl:masterfrom
danielgustafsson wants to merge 1 commit intocurl:masterfrom
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
bagder
approved these changes
Dec 6, 2022
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Also, we sort of reserve the use of the name data all over libcurl code to point to the easy handle struct, and this is used for a different purpose...
Would it also make sense to change the function argument to const char *data you think?
Member
Author
I think it does, maybe even go further and rename from data to |
Member
|
I would approve! |
While perfectly legal to do, clobbering function parameters and using them as local variables is confusing at best and rarely improves code readability. Fix by using a local variable instead, no functionality is changed. This also renames the parameter from data to mime_data since the term data is (soft) reserved for the easy handle struct. Closes: curl#10046 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
danielgustafsson
force-pushed
the
dg-no_clobber
branch
from
5b7e71a to
81c5df3
Compare
Member
Author
|
Pushed a rebase with the discussed changes. |
bagder
approved these changes
Dec 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While perfectly legal to do, clobbering function parameters and using them as local variables is confusing at best and rarely improves code readability. Fix by using a local variable instead, no functionality is changed.