Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: reduce struct field sizes #10186

Closed
wants to merge 1 commit into from
Closed

misc: reduce struct field sizes #10186

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Dec 31, 2022

  • switch bool to BIT()
  • moved some struct fields
  • reduced used data size for a few

@bagder bagder force-pushed the bagder/struct-bits branch from 3bee305 to fbecde2 Compare January 1, 2023 10:30
@bagder bagder force-pushed the bagder/struct-bits branch from 250a73c to 73fb168 Compare January 2, 2023 09:49
@bagder bagder force-pushed the bagder/struct-bits branch from 1af9401 to 96ad91c Compare January 2, 2023 12:22
bagder added a commit that referenced this pull request Jan 3, 2023
@bagder
misc: reduce struct and struct field sizes
22f1f2e 
- by using BIT() instead of bool
- imap: shrink struct
- ftp: make state 'unsigned char'
- ftp: sort ftp_conn struct entries on size
- urldata: use smaller fields for SSL version info storage
- pop3: reduce the pop3_conn struct size
- smtp: reduce the size of the smtp structs

Closes #10186
@bagder bagder force-pushed the bagder/struct-bits branch from 96ad91c to 22f1f2e Compare January 3, 2023 08:26
@bagder
misc: reduce struct and struct field sizes
47e2a84 
- by using BIT() instead of bool
- imap: shrink struct
- ftp: make state 'unsigned char'
- ftp: sort ftp_conn struct entries on size
- urldata: use smaller fields for SSL version info storage
- pop3: reduce the pop3_conn struct size
- smtp: reduce the size of the smtp structs

Closes #10186
@bagder bagder force-pushed the bagder/struct-bits branch from 22f1f2e to 47e2a84 Compare January 3, 2023 23:04
@bagder bagder added the tidy-up label Jan 4, 2023
@bagder bagder closed this in 1485e89 Jan 4, 2023
@bagder bagder deleted the bagder/struct-bits branch January 4, 2023 14:37
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@bagder @bch
misc: reduce struct and struct field sizes
8c877cf 
- by using BIT() instead of bool
- imap: shrink struct
- ftp: make state 'unsigned char'
- ftp: sort ftp_conn struct entries on size
- urldata: use smaller fields for SSL version info storage
- pop3: reduce the pop3_conn struct size
- smtp: reduce the size of the smtp structs

Closes curl#10186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tidy-up
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bagder