Remove dead code in darwinssl for 10.6 support #1028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My read of this is code guarded by |
This #endif ends the 10_6 block nested inside the 10_7 block, not the 10_7 block.
danielgustafsson
force-pushed
the
darwinssl_deadcode
branch
from
0a4f1d2
to
c1e779c
Compare
|
Yes, I stand corrected - I managed to confuse myself of the IOS part of the guard. I think the comment on the |
bagder
approved these changes
Sep 19, 2016
|
Thanks |
|
Thanks for review and for applying. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block supporting macOS 10.6 in
CopyIdentityWithLabel()was duplicated with one copy sitting inside the block only covering 10.7+ and iOS. Remove the block while leaving the live one in place. Passesmake testin a build with--enable-darwinssl --enable-debug.