Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign updocs: Remove that --proto is just used for initial retrieval #1031
Conversation
.. and add that --proto-redir and CURLOPT_REDIR_PROTOCOLS do not override protocols denied by --proto and CURLOPT_PROTOCOLS. - Add a test to enforce: --proto deny must override --proto-redir allow
This comment has been minimized.
This comment has been minimized.
|
I think that wording came from me trying to make it clear that it was affecting already the first request, as opposed to the redir version that only affects what it allows a redirect to. I think your change here is a clear improvement! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jay commentedSep 21, 2016
.. and add that --proto-redir and CURLOPT_REDIR_PROTOCOLS do not
override protocols denied by --proto and CURLOPT_PROTOCOLS.
I think saying "Tells curl to use the listed protocols for its initial retrieval" in
--protois misleading because protocols it denies can't be used on redirect, so I changed it to "Tells curl to limit what protocols it may use in the transfer" and added a test to make sure it stays that way. I wasn't able to go further back than 7.21 but I'd guess this holds true since inception.