multi: stop sending empty HTTP/3 UDP datagrams on Windows #10430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
reviewed
Feb 11, 2023
- Limit the 0-sized send procedure that is used to reset a SOCKET's FD_WRITE to TCP sockets only. Prior to this change the reset was used on UDP sockets as well, but unlike TCP sockets a 0-sized send actually sends out out a datagram. Assisted-by: Marc Hörsken Ref: curl#9203 Fixes curl#9086 Closes #xxxx
jay
force-pushed
the
win_http3_udp_fix
branch
from
21b9060
to
648d5db
Compare
bagder
approved these changes
Feb 12, 2023
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
- Limit the 0-sized send procedure that is used to reset a SOCKET's FD_WRITE to TCP sockets only. Prior to this change the reset was used on UDP sockets as well, but unlike TCP sockets a 0-sized send actually sends out a datagram. Assisted-by: Marc Hörsken Ref: curl#9203 Fixes curl#9086 Closes curl#10430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the reset was used on UDP sockets as well, but unlike TCP sockets a 0-sized send actually sends out out a datagram.
Assisted-by: Marc Hörsken
Ref: #9203
Fixes #9086
Closes #xxxx
@mback2k will this affect activity checks on the extra user fd's that could possibly? be neither TCP nor UDP?