Repository navigation
curl: Add --retry-connrefused - #1064
Closed
gnawhleinad wants to merge 3 commits into
Closed
gnawhleinad wants to merge 3 commits into
gnawhleinad wants to merge 3 commits into
Conversation
to consider ECONNREFUSED as a transient error.
|
@gnawhleinad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @bagder and @captain-caveman2k to be potential reviewers. |
bagder
approved these changes
Nov 6, 2016
bagder
left a comment
bagder
left a comment
Member
There was a problem hiding this comment.
I think this is a feature we can merge. While I would like to see a test case added for this, I don't think our test infra makes that very easy.
Member
|
Thanks! |
Member
I think that could be misinterpreted, if you use it just as --retry-connrefused it doesn't work, so I think it should be adjusted |
jay
added a commit
that referenced
this pull request
Nov 25, 2016
Member
I changed the wording to that since there were no objections, landed in 4bda3e0. |
Bert-R
added a commit
to yonadev/yona-server
that referenced
this pull request
Feb 8, 2017
Improved the test run script in the following ways: * Now doesn't run Gradle in parallel anymore. This addresses the random class loading error and makes the service start up faster * Now automatically starts the tests when all services are up and running (no need to hit enter anymore) * Gives a more clear error message when something fails Note that this requires curl 7.51.1 or later, as we use curl/curl#1064
aristotelos
pushed a commit
to yonadev/yona-server
that referenced
this pull request
Feb 10, 2017
* YD-413 Improved start script Improved the test run script in the following ways: * Now doesn't run Gradle in parallel anymore. This addresses the random class loading error and makes the service start up faster * Now automatically starts the tests when all services are up and running (no need to hit enter anymore) * Gives a more clear error message when something fails Note that this requires curl 7.51.1 or later, as we use curl/curl#1064 * YD-413 Extra error checking Don't execute the tests if activity category loading fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to consider ECONNREFUSED as a transient error.
/cc: @andrewgaul (because #1036)
Any suggestions on a
tests/addition for this change?