Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: Add --retry-connrefused #1064

Closed

Conversation

@gnawhleinad
Copy link
Contributor

@gnawhleinad gnawhleinad commented Oct 9, 2016

to consider ECONNREFUSED as a transient error.

/cc: @andrewgaul (because #1036)

Any suggestions on a tests/ addition for this change?

to consider ECONNREFUSED as a transient error.
@mention-bot
Copy link

@mention-bot mention-bot commented Oct 9, 2016

@gnawhleinad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @bagder and @captain-caveman2k to be potential reviewers.

@bagder
bagder approved these changes Nov 6, 2016
Copy link
Member

@bagder bagder left a comment

I think this is a feature we can merge. While I would like to see a test case added for this, I don't think our test infra makes that very easy.

gnawhleinad added 2 commits Nov 6, 2016
@bagder bagder closed this in cdfda3e Nov 11, 2016
@bagder
Copy link
Member

@bagder bagder commented Nov 11, 2016

Thanks!

@gnawhleinad gnawhleinad deleted the gnawhleinad:gnawhleinad/retry-connrefused branch Nov 11, 2016
@jay
Copy link
Member

@jay jay commented Nov 11, 2016

     --retry-connrefused  Consider "connection refused" a transient error

I think that could be misinterpreted, if you use it just as --retry-connrefused it doesn't work, so I think it should be adjusted

     --retry-connrefused  Retry on connection refused (use with --retry)
@jay jay added the cmdline tool label Nov 11, 2016
@jay
Copy link
Member

@jay jay commented Nov 25, 2016

--retry-connrefused Retry on connection refused (use with --retry)

I changed the wording to that since there were no objections, landed in 4bda3e0.

vulpine pushed a commit to vulpine/curl that referenced this pull request Nov 30, 2016
Bert-R added a commit to yonadev/yona-server that referenced this pull request Feb 8, 2017
Improved the test run script in the following ways:
* Now doesn't run Gradle in parallel anymore. This addresses the random class loading error and makes the service start up faster
* Now automatically starts the tests when all services are up and running (no need to hit enter anymore)
* Gives a more clear error message when something fails

Note that this requires curl 7.51.1 or later, as we use curl/curl#1064
aristotelos added a commit to yonadev/yona-server that referenced this pull request Feb 10, 2017
* YD-413 Improved start script

Improved the test run script in the following ways:
* Now doesn't run Gradle in parallel anymore. This addresses the random class loading error and makes the service start up faster
* Now automatically starts the tests when all services are up and running (no need to hit enter anymore)
* Gives a more clear error message when something fails

Note that this requires curl 7.51.1 or later, as we use curl/curl#1064

* YD-413 Extra error checking

Don't execute the tests if activity category loading fails.
@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.