Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix time_connect and time_appconnect timer statistics #10671

Closed
wants to merge 2 commits into from
Closed

Fix time_connect and time_appconnect timer statistics #10671

wants to merge 2 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Mar 3, 2023

  • time_connect was not updated when the overall connection failed, e.g. when SSL verification was unsuccessful, refs time_connect is 0 when error on 7.88.0/7.88.1 #10670
  • rework gather those values to interrogate involved filters, also from all eyeballing attempts, to report the maximum of those values.
  • added 3 test cases in test_06 to check reported values on successful, partially failed and totally failed connections.

@icing
Fix time_connect and time_appconnect timer statistics
323aff9 
- time_connect was not updated when the overall connection failed,
  e.g. when SSL verification was unsuccessful, refs curl#10670
- rework gather those values to interrogate involved filters,
  also from all eyeballing attempts, to report the maximum of
  those values.
- added 3 test cases in test_06 to check reported values on
  successful, partially failed and totally failed connections.
@icing icing mentioned this pull request Mar 3, 2023
Closed
@bagder
Copy link
Member

bagder commented Mar 6, 2023

Thanks!

@bagder bagder closed this in 2574160 Mar 6, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@icing @bch
connect: fix time_connect and time_appconnect timer statistics
d11c516 
- time_connect was not updated when the overall connection failed,
  e.g. when SSL verification was unsuccessful, refs curl#10670
- rework gather those values to interrogate involved filters,
  also from all eyeballing attempts, to report the maximum of
  those values.
- added 3 test cases in test_06 to check reported values on
  successful, partially failed and totally failed connections.

Reported-by: Master Inspire
Fixes curl#10670
Closes curl#10671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
connecting & proxies libcurl API
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder