Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix crashes when http2 parent stream gets aborted. #1125
I can reproduce a use-after-free situation with libcurl and http2 by doing the following:
Since A knows nothing about B's dependency on it we can't clean this up.
The patch fixes this by keeping a list of all children.
I believe the reprioritization is correct but it should be checked. I couldn't clearly understand what is supposed to happen if you do the following:
B depends on A
My assumption is that this should lead to:
E.g. C would lose its exclusivity when someone's dependency is applied afterwards. I'm not 100 sure this is correct.
The patch also allows for unsetting dependencies.
This is the output from our app reproducing the problem: