tests: fix error handling around UNIX sockets #11265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gvanem Would you mind taking a look? |
dfandrich
force-pushed
the
dfandrich/testerrno
branch
from
818d6c1 to
9b48dea
Compare
|
@dfandrich No change. Same |
|
I'm not sure which versions of Windows is actually running on the CI services.
They might be running an older one that doesn't support UNIX sockets. In any
case, I'll submit this PR since the previous error checking was wrong.
|
dfandrich
force-pushed
the
dfandrich/testerrno
branch
from
9b48dea to
d3136d8
Compare
dfandrich
force-pushed
the
dfandrich/testerrno
branch
from
d3136d8 to
b256eae
Compare
The wrong error code was checked on Windows on UNIX socket failures, which could have caused all UNIX sockets to be reported as having errored and the tests therefore skipped. Also, a useless error message was displayed on socket errors in many test servers on Windows because strerror() doesn't work on WinSock error codes; perror() is overridden there to work on all errors and is used instead. Ref #11258 Closes #11265
dfandrich
force-pushed
the
dfandrich/testerrno
branch
from
b256eae to
0b5c51d
Compare
dfandrich
added a commit
that referenced
this pull request
Jun 9, 2023
The wrong error code was checked on Windows on UNIX socket failures, which could have caused all UNIX sockets to be reported as having errored and the tests therefore skipped. Also, a useless error message was displayed on socket errors in many test servers on Windows because strerror() doesn't work on WinSock error codes; perror() is overridden there to work on all errors and is used instead. Ref #11258 Closes #11265
bagder
reviewed
Jun 9, 2023
| @@ -2779,6 +2779,7 @@ sub displaylogs { | |||
| # a new one shortly. If all runners are busy, wait indefinitely for one to | |||
| # finish. | |||
| my $runnerwait = scalar(@runnersidle) && scalar(@runtests) ? 0 : undef; | |||
| print STDERR "TESTING waiting indefinitely for test completion\n" if(!scalar(@runtests)); | |||
There was a problem hiding this comment.
Is this print a debugging leftover or meant to actually be a plain STDERR output? It looks like an anomaly in the code.
There was a problem hiding this comment.
This is just a debugging leftover. It won't be submitted.
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
The wrong error code was checked on Windows on UNIX socket failures, which could have caused all UNIX sockets to be reported as having errored and the tests therefore skipped. Also, a useless error message was displayed on socket errors in many test servers on Windows because strerror() doesn't work on WinSock error codes; perror() is overridden there to work on all errors and is used instead. Ref curl#11258 Closes curl#11265
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
The wrong error code was checked on Windows on UNIX socket failures, which could have caused all UNIX sockets to be reported as having errored and the tests therefore skipped. Also, a useless error message was displayed on socket errors in many test servers on Windows because strerror() doesn't work on WinSock error codes; perror() is overridden there to work on all errors and is used instead. Ref curl#11258 Closes curl#11265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong error code was checked on Windows, which may have caused all
UNIX sockets to be reported as error and the tests skipped.
Fixes #11258
Closes #11265