Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: rectify the outgoing Cookie: header field size check #11331

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jun 17, 2023

Previously it would count the size of the entire outgoing request and not just the size of only the Cookie: header field - which was the intention.

This could make the check be off by several hundred bytes in some cases.

Previously it would count the size of the entire outgoing request and
not just the size of only the Cookie: header field - which was the
intention.

This could make the check be off by several hundred bytes in some cases.
@bagder bagder added the cookies label Jun 17, 2023
@github-actions github-actions bot added the HTTP label Jun 17, 2023
@bagder bagder closed this in d40e5cc Jun 18, 2023
@bagder bagder deleted the bagder/cookie-size-math branch June 18, 2023 09:08
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Previously it would count the size of the entire outgoing request and
not just the size of only the Cookie: header field - which was the
intention.

This could make the check be off by several hundred bytes in some cases.

Closes curl#11331
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
Previously it would count the size of the entire outgoing request and
not just the size of only the Cookie: header field - which was the
intention.

This could make the check be off by several hundred bytes in some cases.

Closes curl#11331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant