Skip to content

quiche: avoid NULL deref in debug logging#11454

Closed
bagder wants to merge 2 commits intomasterfrom
bagder/quiche-null-deref
Closed

quiche: avoid NULL deref in debug logging#11454
bagder wants to merge 2 commits intomasterfrom
bagder/quiche-null-deref

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Jul 17, 2023

Coverity reported "Dereference after null check"

If stream is NULL and the function exits, the logging must not deref it.

Coverity reported "Dereference after null check"

If stream is NULL and the function exits, the logging must not deref it.
@bagder bagder added the HTTP/3 h3 or quic related label Jul 17, 2023
@bagder bagder requested a review from icing July 17, 2023 18:52
Copy link
Copy Markdown
Contributor

@icing icing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fine, in #11455 I opted for an early return when stream is NULL.

@bagder
Copy link
Copy Markdown
Member Author

bagder commented Jul 17, 2023

Also fine, in #11455 I opted for an early return when stream is NULL.

I believe they're both decent choices. As I already did it this way I think I'll let it be for now.

@bagder bagder closed this in a141c3c Jul 17, 2023
@bagder bagder deleted the bagder/quiche-null-deref branch July 17, 2023 21:27
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Coverity reported "Dereference after null check"

If stream is NULL and the function exits, the logging must not deref it.

Closes curl#11454
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
Coverity reported "Dereference after null check"

If stream is NULL and the function exits, the logging must not deref it.

Closes curl#11454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

2 participants