Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/2, regression on upload EOF handling #11487

Closed
wants to merge 1 commit into from
Closed

HTTP/2, regression on upload EOF handling #11487

wants to merge 1 commit into from

Conversation

icing
Copy link
Contributor

@icing icing commented Jul 20, 2023

@icing
HTTP/2, regression on upload EOF handling
eb8970f 
- refs curl#11485
- a regression introduced by c9ec851
  where optimization of small POST bodies leads to a new code path
  for such uploads that did not trigger the "done sending" event
- add triggering this event for early "upload_done" situations
@github-actions github-actions bot added the HTTP label Jul 20, 2023
@icing icing mentioned this pull request Jul 20, 2023
Closed
@bagder bagder closed this in f9314f3 Jul 20, 2023
@calvin2021y calvin2021y mentioned this pull request Jul 21, 2023
Closed
ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
@icing @ptitSeb
http2: fix regression on upload EOF handling
9185949 
- a regression introduced by c9ec851
  where optimization of small POST bodies leads to a new code path
  for such uploads that did not trigger the "done sending" event
- add triggering this event for early "upload_done" situations

Fixes curl#11485
Closes curl#11487
Reported-by: Aleksander Mazur
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
HTTP
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder