Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mingw: delete support for legacy mingw.org toolchain #11625

Closed
wants to merge 15 commits into from
Closed

mingw: delete support for legacy mingw.org toolchain #11625

wants to merge 15 commits into from

Commits on Sep 21, 2023

  1. mingw: delete support for old/classic/legacy toolchain version 

    Drop support for "old" / "legacy" / "classic" MinGW or "mingw32":
https://en.wikipedia.org/wiki/MinGW, https://osdn.net/projects/mingw/
Its homepage used to be http://mingw.org/ [no HTTPS], and broken now.
It supported the x86 CPU only and used a old Windows API header and
implib set, often causing issues. It also misses most modern Windows
features, offering old versions of both binutils and gcc (no
llvm/clang support). It was last updated 2 years ago.

curl now relies on toolchains based on the mingw-w64 project:

https://www.mingw-w64.org/  https://sourceforge.net/projects/mingw-w64/
https://www.msys2.org/  https://github.com/msys2/msys2
https://github.com/mstorsjo/llvm-mingw

Also available via Linux and macOS package managers.

Closes curl#11625
    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    017305a View commit details
    Browse the repository at this point in the history

  2. delete one more reference

    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f25a5fc View commit details
    Browse the repository at this point in the history

  3. formatting

    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e112772 View commit details
    Browse the repository at this point in the history

  4. use __MINGW32__ instead of __MINGW64_VERSION_MAJOR 

    We now require mingw-w64, so `__MINGW64_VERSION_MAJOR` is always defined
when `__MINGW32__` is defined. Update conditions to use the shorter,
simpler macro. Then delete always-true conditions and delete code guarded
by always-false conditions.
    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    f36a68d View commit details
    Browse the repository at this point in the history

  5. update INSTALL.md

    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    556e6c9 View commit details
    Browse the repository at this point in the history

  6. we no longer need _mingw.h, drop

    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    e48d1ac View commit details
    Browse the repository at this point in the history

  7. delete cast added for mingw32 (in 2004) 

    Reverts ae2f002 (2004-07-29)
    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    02e6b83 View commit details
    Browse the repository at this point in the history

  8. delete mingw workaround for ARRAYSIZE() 

    The comment and PR history doesn't tell more or mention
mingw version, so take a chance on this and assume it
affected old mingw.

My fresh copy of mingw-w64 does have an `ARRAYSIZE()`
macro defined by Windows headers.

Originally added in 8beff43 curl#8419
    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4bf0d00 View commit details
    Browse the repository at this point in the history

  9. apply to recent commit in master

    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    3e760aa View commit details
    Browse the repository at this point in the history

  10. delete mingw32 compatibility constants 

    added in 3d3a3f9
    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    402f5b7 View commit details
    Browse the repository at this point in the history

  11. except those not yet present in mingw-w64 1.0

    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c5e8a7a View commit details
    Browse the repository at this point in the history

  12. delete macro present in mingw-w64 1.0 

    https://sourceforge.net/projects/mingw-w64/files/mingw-w64/mingw-w64-release/
    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    6ba06de View commit details
    Browse the repository at this point in the history

  13. delete macros present in mingw-w64 1.0

    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    765f3f4 View commit details
    Browse the repository at this point in the history

  14. mingw: delete support for old/classic/legacy toolchain version (fixup) 

    instead of adding `const` to the cast, drop the cast altogther as the
type is already a `const` and `unsigned char` and `BYTE` are equivalent.
    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    2f2882d View commit details
    Browse the repository at this point in the history

  15. delete leftover comma

    @vszakats
    vszakats committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    29c4a5f View commit details
    Browse the repository at this point in the history