Fix aws sigv4 date twice #11754
Closed
Fix aws sigv4 date twice #11754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outscale-mgo
force-pushed
the
fix-aws-sigv4-date-twice
branch
from
b2a2651
to
94407cf
Compare
jay
reviewed
Aug 29, 2023
outscale-mgo
force-pushed
the
fix-aws-sigv4-date-twice
branch
from
94407cf
to
c78a3d5
Compare
bagder
reviewed
Aug 29, 2023
lib/http_aws_sigv4.c
Outdated
| @@ -612,14 +609,14 @@ CURLcode Curl_output_aws_sigv4(struct Curl_easy *data, bool proxy) | |||
| "Credential=%s/%s, " | |||
| "SignedHeaders=%s, " | |||
| "Signature=%s\r\n" | |||
| "%s\r\n" | |||
| "%s" /* if providedd by user, must not be add */ | |||
There was a problem hiding this comment.
This comment does not make sense (apart from the broken English). If this header is provided by the user, it is not added here no, but it is still added to the request.
There was a problem hiding this comment.
I've just changed it to:
/*
* date_header is added here, only if it wasn't
* pass as header (using -H),
* otherwise, date_header include \r\n
*/
outscale-mgo
force-pushed
the
fix-aws-sigv4-date-twice
branch
3 times, most recently
from
b5c2405
to
3d8bccc
Compare
bagder
reviewed
Aug 29, 2023
lib/http_aws_sigv4.c
Outdated
| "%s\r\n" | ||
| /* | ||
| * date_header is added here, only if it wasn't | ||
| * pass as header (using -H), |
There was a problem hiding this comment.
The header is actually set with CURLOPT_HTTPHEADER since this is library code.
fix curl#11738 When the user was providing the header X-XXX-Date, the header was re-added during signature computation, and we had it twice in the request. Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com>
outscale-mgo
force-pushed
the
fix-aws-sigv4-date-twice
branch
from
3d8bccc
to
1483755
Compare
|
Thanks |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
When the user was providing the header X-XXX-Date, the header was re-added during signature computation, and we had it twice in the request. Reported-by: apparentorder@users.noreply.github.com Signed-off-by: Matthias Gatto <matthias.gatto@outscale.com> Fixes: curl#11738 Closes: curl#11754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11738