Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer: also stop the sending on closed connection #11795

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 4, 2023

Previously this cleared the receiving bit only but in some cases it is also still sending (like a request-body) when disconnected and neither direction can continue then.

Fixes #11769
Reported-by: Oleg Jukovec

@bagder
Copy link
Member Author

bagder commented Sep 4, 2023

I did not manage to create a test case for this scenario yet.

Previously this cleared the receiving bit only but in some cases it is
also still sending (like a request-body) when disconnected and neither
direction can continue then.

Fixes #11769
Reported-by: Oleg Jukovec
Closes #11795
@ligurio
Copy link
Contributor

ligurio commented Sep 5, 2023

Daniel @bagder, do you plan to release a new version with this fix in the nearest time?

UPDATED: The answer is on website:

This is work in progress and will change before the release goes public on 2023-09-13.
https://curl.se/dev/release-notes.html

I did not manage to create a test case for this scenario yet.

Seems chaos testing is required for curl :) Tool like toxiproxy 1 looks suitable for such purpose.

Footnotes

  1. https://github.com/Shopify/toxiproxy

@dfandrich
Copy link
Contributor

dfandrich commented Sep 5, 2023 via email

ptitSeb pushed a commit to wasix-org/curl that referenced this pull request Sep 25, 2023
Previously this cleared the receiving bit only but in some cases it is
also still sending (like a request-body) when disconnected and neither
direction can continue then.

Fixes curl#11769
Reported-by: Oleg Jukovec
Closes curl#11795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

libcurl does not finish CURLOPT_UPLOAD request after a connection lost without data tranfer
3 participants