Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape: replace Curl_isunreserved with ISUNRESERVED #11846

Closed
wants to merge 1 commit into from

Commits on Sep 13, 2023

  1. escape: replace Curl_isunreserved with ISUNRESERVED

    - Use the ALLCAPS version of the macro so that it is clear a macro is
      being called that evaluates the variable multiple times.
    
    - Also capitalize macro isurlpuntcs => ISURLPUNTCS since it evaluates
      a variable multiple times.
    
    This is a follow-up to 291d225 which changed Curl_isunreserved into an
    alias macro for ISUNRESERVED. The problem is the former is not easily
    identified as a macro by the caller, which could lead to a bug.
    
    For example, ISUNRESERVED(*foo++) is easily identifiable as wrong but
    Curl_isunreserved(*foo++) is not even though they both are the same.
    
    Closes #xxxx
    jay committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d9dcacb View commit details
    Browse the repository at this point in the history