-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CURLSSLBACKEND_ALL enum #11903
add CURLSSLBACKEND_ALL enum #11903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you did not update symbols-in-versions
so test 1119 fails.
Thanks! What will the next version be? 8.3.1? |
We are fairly sure it will become 8.4.0 so I think you can use that. |
IMO |
Yeah, maybe *_NONE instead? |
Perhaps |
cbc2bc0
to
6d58bd6
Compare
Oh right. But maybe we should then rather change the documentation to use *NONE instead of -1? As far as I can see, that gives the same result... |
Ah, well, that would certainly be even easier if it indeed does the same thing :-) I'm a bit worried about this note in the man-page that I missed before:
That seems to imply that I added #11909 as an alternative to this PR. |
[ssl]: add CURLSSLBACKEND_ALL enum for cleaner code and examples This is to make code that now does `(curl_sslbackend)-1` clearer and easier to read: /* list the available ones */ const curl_ssl_backend **list; curl_global_sslset(CURLSSLBACKEND_ALL, NULL, &list); Signed-off-by: Ted Lyngmo <ted@lyncon.se>
6d58bd6
to
5975535
Compare
Since #11909 has been approved, this PR is meaningless. Closing. |
[ssl]: add CURLSSLBACKEND_ALL enum for cleaner code and examples
This is to make code that now does
(curl_sslbackend)-1
clearerand easier to read: