Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testcase and fix for pausing h2 streams #11989

Closed
wants to merge 5 commits into from
Closed

Testcase and fix for pausing h2 streams #11989

wants to merge 5 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Sep 29, 2023

@icing
Testcase and fix for pausing h2 streams
760c564 
- refs curl#11982 where it was noted that paused transfers may
  close successfully without delivering the complete data
- made sample poc into tests/http/client/h2-pausing.c and
  added test_02_27 to reproduce
@github-actions github-actions bot added the tests label Sep 29, 2023
@icing icing mentioned this pull request Sep 29, 2023
Closed
@icing
Copy link
Contributor Author

icing commented Sep 29, 2023

Linux event-based is timing out after 90 min.

@bagder
Copy link
Member

bagder commented Sep 29, 2023

@icing it happens already without this PR though, like in #11990 ...

@bagder
Copy link
Member

bagder commented Sep 30, 2023

@icing I presume this is ready to land?

@icing
Copy link
Contributor Author

icing commented Sep 30, 2023

@icing I presume this is ready to land?

Yes. I was just hesitant because of the event-based thing. But if that is caused by another merge, this one is ready.

@bagder bagder closed this in 6b9a591 Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icing @bagder